Skip to content

feat: remove Account Config DA from customize DA flow, add default value for prefix using random string generator and update logic that handles default resource group lookup #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

feat: remove Account Config DA from customize DA flow, add default value for prefix using random string generator and update logic that handles default resource group lookup #332

merged 5 commits into from
Oct 20, 2025

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Oct 17, 2025 •
edited
Loading

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
feat: remove Account Config DA from customize DA flow, add default va…
0260516 
…lue for prefix using random string generator and update logic that handles default resource group lookup
@ocofaigh
RG update
c7b9a97
@ocofaigh
Merge branch 'main' of github.com:terraform-ibm-modules/terraform-ibm…
d516ff8 
…-scc-workload-protection into acc
@ocofaigh
bump deps
a8fed75
@ocofaigh ocofaigh marked this pull request as ready for review October 20, 2025 07:36
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 797ee45 into main Oct 20, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the acc branch October 20, 2025 09:11
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-butler-irl daniel-butler-irl daniel-butler-irl left review comments

@akocbek akocbek Awaiting requested review from akocbek akocbek is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocofaigh @terraform-ibm-modules-ops @daniel-butler-irl